🎨 Make call_by_need deal with functions returning references#281
Merged
lukevalenty merged 1 commit intointel:mainfrom Sep 30, 2025
Merged
🎨 Make call_by_need deal with functions returning references#281lukevalenty merged 1 commit intointel:mainfrom
call_by_need deal with functions returning references#281lukevalenty merged 1 commit intointel:mainfrom
Conversation
Problem: - If `call_by_need` calls a function returning a reference, it decays the result into the results tuple. It should preserve lvalue references generated in this way. Solution: - Preserve lvalue references in the results tuple.
lukevalenty
approved these changes
Sep 30, 2025
mjcaisse-intel
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
call_by_needcalls a function returning a reference, it decays the result into the results tuple. It should preserve lvalue references generated in this way.Solution: